Updating toolkit/scripts/build_cargo_cache.sh
#12309
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Packaging
Tools
3.0-dev
osamaesmailmsft
force-pushed
the
osamaesmail/cargo_cache
branch
from
352268d to
611efe5
Compare
toolkit/scripts/build_cargo_cache.sh
Outdated
| echo "Fetching dependencies to a temporary cache in $DIRECTORY_NAME." | ||
|
|
||
| #TODO: installing rust as auto-patcher does not have it installed by default. Possibly remove if auto-patcher will be changed to have rust included. | ||
| sudo dnf install -y rust || sudo apt install -y rustc |
There was a problem hiding this comment.
Hmm, I am not entirely sure if it make sense to have this in the script itself or move it out into pipeline code? I think generally we keep it in pipeline code, but might make it easier for anyone running this manually too
osamaesmailmsft
force-pushed
the
osamaesmail/cargo_cache
branch
from
3c85964 to
137741e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
I updated the
toolkit/scripts/build_cargo_cache.shscript to improve the general cargo script, updated thefluxscript, and created a new script forvirtiofsd.Change Log
toolkit/scripts/build_cargo_cache.shto be usable for anycargobuildfluxscript to use the newbuild_cargo_cache.shvirtiofsdDoes this affect the toolchain?
NO
Test Methodology